Chromium Code Reviews Chromium Code Reviews
Issue 2185193002:
Enable Local CSE by default (Closed)
Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master| Index: src/IceClFlags.def |
| diff --git a/src/IceClFlags.def b/src/IceClFlags.def |
| index 0fabb9cf51ed1f45a3267210ec921ec5f49926c3..b4f2ab2c53ba69027084b3072cc33d3ab4405ad8 100644 |
| --- a/src/IceClFlags.def |
| +++ b/src/IceClFlags.def |
| @@ -140,9 +140,14 @@ struct dev_list_flag {}; |
| "information to stdout at the end of program execution."), \ |
| cl::init(false)) \ |
| \ |
| - X(EnableExperimental, bool, dev_opt_flag, "enable-experimental", \ |
| - cl::desc("Enable Optimizations not yet part of O2"), \ |
| - cl::init(false)) \ |
| + X(LocalCSE, Ice::LCSEOptions, dev_opt_flag, "lcse", \ |
| + cl::desc("Local Common Subexpression elimination"), \ |
|
Jim Stichnoth
2016/07/29 14:49:02
I would use all lowercase apart from "Local".
manasijm
2016/08/01 17:39:24
Done.
|
| + cl::init(Ice::LCSEOptions::EnabledSSA), \ |
| + cl::values( \ |
| + clEnumValN(Ice::LCSEOptions::Disabled, "0", "disabled"), \ |
| + clEnumValN(Ice::LCSEOptions::EnabledSSA, "enabled", "assume-ssa"), \ |
|
Jim Stichnoth
2016/07/29 14:49:02
unindent
manasijm
2016/08/01 17:39:24
Done.
|
| + clEnumValN(Ice::LCSEOptions::EnabledNoSSA,"no-ssa" , "no-assume-ssa"), \ |
| + clEnumValEnd)) \ |
| \ |
| X(EnablePhiEdgeSplit, bool, dev_opt_flag, "phi-edge-split", \ |
| cl::desc("Enable edge splitting for Phi lowering"), cl::init(true)) \ |
| @@ -184,7 +189,7 @@ struct dev_list_flag {}; |
| cl::init(false)) \ |
| \ |
| X(LocalCseMaxIterations, int, dev_opt_flag, "lcse-max-iters", \ |
| - cl::desc("Number of times local-cse is run on a block"), cl::init(2)) \ |
| + cl::desc("Number of times local-cse is run on a block"), cl::init(1)) \ |
| \ |
| X(LoopInvariantCodeMotion, bool, dev_opt_flag, "licm", \ |
| cl::desc("Hoist loop invariant arithmetic operations"), cl::init(false)) \ |
