Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 2185163002: Ignore RTT measurements greater than 30 seconds in QUIC and limit the LOG(WARNING) to 10. Protected… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128366346
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index bbe15688bbc8f8c7397eb4ab7f0b535a7b622ac0..fc075a0c40d85d07b20846f9736d04e757413da0 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -753,9 +753,13 @@ bool QuicSentPacketManager::MaybeUpdateRTT(const QuicAckFrame& ack_frame,
if (FLAGS_quic_socket_walltimestamps &&
send_delta.ToSeconds() > kMaxSendDeltaSeconds) {
// send_delta can be very high if local clock is changed mid-connection.
- LOG(WARNING) << "Excessive send delta: " << send_delta.ToSeconds()
- << ", setting to: " << kMaxSendDeltaSeconds;
- send_delta = QuicTime::Delta::FromSeconds(kMaxSendDeltaSeconds);
+ LOG(WARNING)
+ << "Excessive send delta: " << send_delta.ToSeconds()
+ << ", setting to: " << kMaxSendDeltaSeconds
+ << " largest_observed:" << ack_frame.largest_observed
+ << " ack_receive_time:" << ack_receive_time.ToDebuggingValue()
+ << " sent_time:" << transmission_info.sent_time.ToDebuggingValue();
+ return false;
}
rtt_stats_.UpdateRtt(send_delta, ack_frame.ack_delay_time, ack_receive_time);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698