Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2185133004: Update status files now that tear off closure equality works across reloads (Closed)

Created:
4 years, 4 months ago by Cutch
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status files now that tear off closure equality works across reloads BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8b3a8bbe0f3657f9574a7251ba620914d0454fc0

Patch Set 1 #

Total comments: 2

Patch Set 2 : isolate.status updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 4 months ago (2016-07-28 00:05:56 UTC) #3
rmacnak
lgtm w/o isolate tests https://codereview.chromium.org/2185133004/diff/1/tests/isolate/isolate.status File tests/isolate/isolate.status (left): https://codereview.chromium.org/2185133004/diff/1/tests/isolate/isolate.status#oldcode212 tests/isolate/isolate.status:212: function_send_test: Pass, Fail # Closure ...
4 years, 4 months ago (2016-07-28 16:32:56 UTC) #4
Cutch
https://codereview.chromium.org/2185133004/diff/1/tests/isolate/isolate.status File tests/isolate/isolate.status (left): https://codereview.chromium.org/2185133004/diff/1/tests/isolate/isolate.status#oldcode212 tests/isolate/isolate.status:212: function_send_test: Pass, Fail # Closure identity On 2016/07/28 16:32:56, ...
4 years, 4 months ago (2016-07-28 19:41:52 UTC) #5
Cutch
4 years, 4 months ago (2016-07-28 19:42:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8b3a8bbe0f3657f9574a7251ba620914d0454fc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698