Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2185123004: Make video-auotplay layout test use gpu acceleration. (Closed)

Created:
4 years, 4 months ago by chcunningham
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, DaleCurtis
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make video-auotplay layout test use gpu acceleration. Test is failing with logs complaining about GL. Suspected to be the same issue as encountered with other android tests that attempt to use hw acceleration. Mesa is not compatible with Android's SurfaceTexture. BUG=599975 TEST=New virtual test passes. Committed: https://crrev.com/4172ea2c032994879605fdc6f68ba466a946d8cd Cr-Commit-Position: refs/heads/master@{#408488}

Patch Set 1 #

Patch Set 2 : Missing files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/SmokeTests View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/media-gpu-accelerated/media/README.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
chcunningham
4 years, 4 months ago (2016-07-28 19:12:45 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-28 19:14:21 UTC) #3
chcunningham
Hey Dirk, the android_blink_rel bot didn't run any webkit_tests when I triggered for that CL ...
4 years, 4 months ago (2016-07-28 20:14:06 UTC) #6
DaleCurtis
lgtm
4 years, 4 months ago (2016-07-28 20:14:12 UTC) #7
Dirk Pranke
On 2016/07/28 20:14:06, chcunningham wrote: > Hey Dirk, the android_blink_rel bot didn't run any webkit_tests ...
4 years, 4 months ago (2016-07-28 20:35:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185123004/20001
4 years, 4 months ago (2016-07-28 21:02:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 21:35:04 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:37:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4172ea2c032994879605fdc6f68ba466a946d8cd
Cr-Commit-Position: refs/heads/master@{#408488}

Powered by Google App Engine
This is Rietveld 408576698