Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2185123003: [interpreter] Fix peephole rule on eliding last before jump. (Closed)

Created:
4 years, 4 months ago by oth
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix peephole rule on eliding last before jump. BUG=chromium:629792 LOG=N Committed: https://crrev.com/02b0985335708736223218289e9a4589d927905d Cr-Commit-Position: refs/heads/master@{#38140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/interpreter/bytecode-peephole-optimizer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + test/mjsunit/ignition/regress-629792-source-position-on-jump.js View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
oth
PTAL, thanks.
4 years, 4 months ago (2016-07-28 13:57:16 UTC) #1
oth
PTAL v2 :-)
4 years, 4 months ago (2016-07-28 13:58:06 UTC) #3
rmcilroy
LGTM, thanks!
4 years, 4 months ago (2016-07-28 13:59:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185123003/1
4 years, 4 months ago (2016-07-28 14:16:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 14:41:19 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 14:41:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02b0985335708736223218289e9a4589d927905d
Cr-Commit-Position: refs/heads/master@{#38140}

Powered by Google App Engine
This is Rietveld 408576698