Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

Issue 2185033002: Emulation.setVirtualTimePolicy to have an optional virtual time budge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename parameter Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/InspectorEmulationAgent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
diff --git a/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp b/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
index 495b7921db61a413966621c2baca434874f0e78d..326712afcbc2f0488f9b643f30838e9d9ef96685 100644
--- a/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
+++ b/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp
@@ -9,6 +9,8 @@
#include "core/frame/Settings.h"
#include "core/page/Page.h"
#include "platform/geometry/DoubleRect.h"
+#include "public/platform/Platform.h"
+#include "public/platform/WebThread.h"
#include "public/platform/WebViewScheduler.h"
#include "web/DevToolsEmulator.h"
#include "web/WebLocalFrameImpl.h"
@@ -30,6 +32,7 @@ InspectorEmulationAgent* InspectorEmulationAgent::create(WebLocalFrameImpl* webL
InspectorEmulationAgent::InspectorEmulationAgent(WebLocalFrameImpl* webLocalFrameImpl, Client* client)
: m_webLocalFrameImpl(webLocalFrameImpl)
, m_client(client)
+ , m_virtualTimeBudgetExpiredTask(CancellableTaskFactory::create(this, &InspectorEmulationAgent::virtualTimeBudgetExpired))
{
}
@@ -93,18 +96,28 @@ void InspectorEmulationAgent::setCPUThrottlingRate(ErrorString*, double throttli
m_client->setCPUThrottlingRate(throttlingRate);
}
-void InspectorEmulationAgent::setVirtualTimePolicy(ErrorString*, const String& in_policy)
+void InspectorEmulationAgent::setVirtualTimePolicy(ErrorString*, const String& in_policy, const Maybe<int>& in_budget)
{
if (protocol::Emulation::VirtualTimePolicyEnum::Advance == in_policy) {
- m_webLocalFrameImpl->view()->scheduler()->enableVirtualTime();
m_webLocalFrameImpl->view()->scheduler()->setVirtualTimePolicy(WebViewScheduler::VirtualTimePolicy::ADVANCE);
} else if (protocol::Emulation::VirtualTimePolicyEnum::Pause == in_policy) {
- m_webLocalFrameImpl->view()->scheduler()->enableVirtualTime();
m_webLocalFrameImpl->view()->scheduler()->setVirtualTimePolicy(WebViewScheduler::VirtualTimePolicy::PAUSE);
} else if (protocol::Emulation::VirtualTimePolicyEnum::PauseIfNetworkFetchesPending == in_policy) {
- m_webLocalFrameImpl->view()->scheduler()->enableVirtualTime();
m_webLocalFrameImpl->view()->scheduler()->setVirtualTimePolicy(WebViewScheduler::VirtualTimePolicy::DETERMINISTIC_LOADING);
}
+ m_webLocalFrameImpl->view()->scheduler()->enableVirtualTime();
+
+ if (in_budget.isJust()) {
+ WebTaskRunner* taskRunner = Platform::current()->currentThread()->getWebTaskRunner();
+ long long delayMillis = static_cast<long long>(in_budget.fromJust());
+ taskRunner->postDelayedTask(BLINK_FROM_HERE, m_virtualTimeBudgetExpiredTask->cancelAndCreate(), delayMillis);
+ }
+}
+
+void InspectorEmulationAgent::virtualTimeBudgetExpired()
+{
+ m_webLocalFrameImpl->view()->scheduler()->setVirtualTimePolicy(WebViewScheduler::VirtualTimePolicy::PAUSE);
+ frontend()->virtualTimeBudgetExpired();
}
DEFINE_TRACE(InspectorEmulationAgent)
« no previous file with comments | « third_party/WebKit/Source/web/InspectorEmulationAgent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698