Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218503002: Remove telemetry.web_components.ui charts in favor of tvcm.ui charts (Closed)

Created:
6 years, 8 months ago by nduca
Modified:
6 years, 8 months ago
Reviewers:
dsinclair
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Remove telemetry.web_components.ui charts in favor of tvcm.ui charts Trace-viewer ended up needing charts too so we moved the charts upstream. This does a deps roll to that fresh version and removes the local copies. TBR=dsinclair NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260450

Patch Set 1 #

Patch Set 2 : remove d3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -813 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/web_components/ui/bar_chart.css View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/bar_chart.js View 1 chunk +0 lines, -180 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/bar_chart_unittest.js View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/chart_base.html View 1 chunk +0 lines, -26 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/chart_base.js View 1 chunk +0 lines, -194 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/d3.js View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/line_chart.css View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/line_chart.js View 1 chunk +0 lines, -120 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/line_chart_unittest.js View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/pie_chart.css View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/pie_chart.js View 1 chunk +0 lines, -119 lines 0 comments Download
D tools/telemetry/telemetry/web_components/ui/pie_chart_unittest.js View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/telemetry/third_party/d3/LICENSE View 1 1 chunk +0 lines, -26 lines 0 comments Download
D tools/telemetry/third_party/d3/README.chromium View 1 1 chunk +0 lines, -15 lines 0 comments Download
D tools/telemetry/third_party/d3/d3.min.js View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
nduca
6 years, 8 months ago (2014-03-30 02:35:50 UTC) #1
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 8 months ago (2014-03-30 02:35:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/218503002/1
6 years, 8 months ago (2014-03-30 02:36:13 UTC) #3
nduca
The CQ bit was unchecked by nduca@chromium.org
6 years, 8 months ago (2014-03-30 02:36:18 UTC) #4
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 8 months ago (2014-03-30 02:37:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/218503002/20001
6 years, 8 months ago (2014-03-30 02:37:30 UTC) #6
nduca
The CQ bit was unchecked by nduca@chromium.org
6 years, 8 months ago (2014-03-30 02:37:48 UTC) #7
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 8 months ago (2014-03-30 04:11:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/218503002/20001
6 years, 8 months ago (2014-03-30 04:11:59 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 04:13:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-30 04:13:59 UTC) #11
nduca
The CQ bit was checked by nduca@chromium.org
6 years, 8 months ago (2014-03-30 04:15:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/218503002/20001
6 years, 8 months ago (2014-03-30 04:15:17 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 17:31:46 UTC) #14
Message was sent while issue was closed. 
Change committed as 260450

Powered by Google App Engine
This is Rietveld 408576698