Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/opus/BUILD.gn

Issue 2184993002: Remove warning suppression for Wexpansion-to-defined violation for Opus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/opus/opus.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/opus/BUILD.gn
diff --git a/third_party/opus/BUILD.gn b/third_party/opus/BUILD.gn
index ab8a197d7f449d5b4a31058afef8692f084a9474..a32d2e37753713974670c817320dfd914e46dbe2 100644
--- a/third_party/opus/BUILD.gn
+++ b/third_party/opus/BUILD.gn
@@ -56,13 +56,6 @@ if (use_opus_rtcd) {
}
}
-config("opus_warnings") {
- if (is_clang && !is_nacl) {
- # TODO(thakis): Remove once silk/macros.h has been fixed
- cflags = [ "-Wno-expansion-to-defined" ]
- }
-}
-
static_library("opus") {
gypi_values = exec_script("//build/gypi_to_gn.py",
[ rebase_path("opus_srcs.gypi") ],
@@ -81,12 +74,7 @@ static_library("opus") {
]
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [
- "//build/config/compiler:no_chromium_code",
-
- # Must be after no_chromium_code to have an effect:
- ":opus_warnings",
- ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
public_configs = [ ":opus_config" ]
cflags = []
« no previous file with comments | « no previous file | third_party/opus/opus.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698