Convert extend-by-character-[1-6].html to use assert_selection

Convert extend-by-character-[1-6].html to use assert_selection

This patch converts "extend-by-character-[1-6].html" in "editing/selection" to
use |assert_selection()| test harness to simplify test files and consolidate
into "extend_by_character.html" to run tests faster.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Committed: https://crrev.com/2b0ece62b99aeb105a26423d1d0390c722b4fef3
Cr-Commit-Position: refs/heads/master@{#408319}

[yosin_UTC9, 2016-07-27 06:12:58]

Description was changed from

==========
2016-07-27T15:09:26

BUG=
==========

to

==========
Convert extend-by-character-[1-6].html to use assert_selection

This patch converts "extend-by-character-[1-6].html" in "editing/selection" to
use |assert_selection()| test harness to simplify test files and consolidate
into "extend_by_character.html" to run tests faster.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file
==========

[yosin_UTC9, 2016-07-27 06:13:07]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 06:13:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-07-27 07:39:24]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-07-27 07:39:24]

PTAL

[commit-bot: I haz the power, 2016-07-27 08:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 08:26:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-07-27 08:30:12]

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html
(right):

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:45:
'<i>|F    and seven</i> years <b>  as </b>our fathers  f upon this',
The initial caret should be before "and".

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:57:
'<i>^F    and seven</i> years <b>  as </b>our fathers  f upon this',
The final selection should start before "and".

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:60:
'<br>men are created equ|al.',
The final selection should end before the last ".".

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:65:
test(() => assert_selection(
The initial caret should be before "a", and the test should have both forward
and backward extensions.

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:92:
test(() => assert_selection(
The initial caret should be before "F", and the test should have both forward
and backward extensions.

[yosin_UTC9, 2016-07-27 09:08:18]

PTAL

Updated.

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html
(right):

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:45:
'<i>|F    and seven</i> years <b>  as </b>our fathers  f upon this',
On 2016/07/27 at 08:30:11, Xiaocheng wrote:
> The initial caret should be before "and".

Done

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:57:
'<i>^F    and seven</i> years <b>  as </b>our fathers  f upon this',
On 2016/07/27 at 08:30:11, Xiaocheng wrote:
> The final selection should start before "and".

Done.

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:60:
'<br>men are created equ|al.',
On 2016/07/27 at 08:30:11, Xiaocheng wrote:
> The final selection should end before the last ".".

Done.

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:65:
test(() => assert_selection(
On 2016/07/27 at 08:30:11, Xiaocheng wrote:
> The initial caret should be before "a", and the test should have both forward
and backward extensions.

Oops.
Done.

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:92:
test(() => assert_selection(
On 2016/07/27 at 08:30:11, Xiaocheng wrote:
> The initial caret should be before "F", and the test should have both forward
and backward extensions.

I omits 33 times of move-forward-by-character, since this test is for
"extend-backward".
We don't want to fail when move-forward-by-character is broken.

[Xiaocheng, 2016-07-27 10:21:06]

lgtm

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html
(right):

https://codereview.chromium.org/2184953002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_character.html:92:
test(() => assert_selection(
On 2016/07/27 at 09:08:18, Yosi_UTC9 wrote:
> On 2016/07/27 at 08:30:11, Xiaocheng wrote:
> > The initial caret should be before "F", and the test should have both
forward and backward extensions.
> 
> I omits 33 times of move-forward-by-character, since this test is for
"extend-backward".
> We don't want to fail when move-forward-by-character is broken.

OK, that's acceptable.

[Xiaocheng, 2016-07-27 10:23:37]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-07-27 10:24:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-07-27 11:27:13]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2016-07-27 11:27:54]

Oops, there are bugs in the test cases...

[yosin_UTC9, 2016-07-28 01:40:18]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-07-28 01:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2184953002/#ps40001
(title: "2016-07-28T10:36:48 Adopt to Linux behavior")

[commit-bot: I haz the power, 2016-07-28 01:40:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 01:59:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 01:59:44]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[yosin_UTC9, 2016-07-28 02:25:04]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-07-28 02:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 02:52:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-28 02:54:22]

Description was changed from

==========
Convert extend-by-character-[1-6].html to use assert_selection

This patch converts "extend-by-character-[1-6].html" in "editing/selection" to
use |assert_selection()| test harness to simplify test files and consolidate
into "extend_by_character.html" to run tests faster.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file
==========

to

==========
Convert extend-by-character-[1-6].html to use assert_selection

This patch converts "extend-by-character-[1-6].html" in "editing/selection" to
use |assert_selection()| test harness to simplify test files and consolidate
into "extend_by_character.html" to run tests faster.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Committed: https://crrev.com/2b0ece62b99aeb105a26423d1d0390c722b4fef3
Cr-Commit-Position: refs/heads/master@{#408319}
==========

[commit-bot: I haz the power, 2016-07-28 02:54:23]

Patchset 3 (id:??) landed as
https://crrev.com/2b0ece62b99aeb105a26423d1d0390c722b4fef3
Cr-Commit-Position: refs/heads/master@{#408319}