Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2184933003: [Chromecast] Include output screen resolution in OSD rect info (Closed)

Created:
4 years, 4 months ago by halliwell
Modified:
4 years, 4 months ago
Reviewers:
derekjchow1, gfhuang
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, gfhuang+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Include output screen resolution in OSD rect info Current OSD SetClipRect API is ambiguous, as it doesn't specify what coordinate space the clip rect is in. This is solved by passing the OSD screen resolution. Additionally, pass the output screen resolution through. Some implementations need this info in order to scale the OSD correctly. They could probably get the screen res in vendor-specific ways but it's more convenient to just plumb it through here. BUG=internal b/30025430 TEST=manual OSD test on different screen resolutions Committed: https://crrev.com/8da342224564207f57eb2d565c2585e3672c4f2f Cr-Commit-Position: refs/heads/master@{#408187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chromecast/graphics/osd_plane_default.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromecast/public/osd_plane.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
halliwell
gfhuang: want to confirm this won't cause problems (I think nobody else implements OSD interface, ...
4 years, 4 months ago (2016-07-27 16:05:44 UTC) #3
gfhuang
On 2016/07/27 16:05:44, halliwell wrote: > gfhuang: want to confirm this won't cause problems (I ...
4 years, 4 months ago (2016-07-27 17:07:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184933003/1
4 years, 4 months ago (2016-07-27 17:45:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 18:22:29 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:24:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8da342224564207f57eb2d565c2585e3672c4f2f
Cr-Commit-Position: refs/heads/master@{#408187}

Powered by Google App Engine
This is Rietveld 408576698