Issue 218493017: Revert 260949 "Move gtest/gmock BUILD.gn files to main tree."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218493017: Revert 260949 "Move gtest/gmock BUILD.gn files to main tree." (Closed)

Created:
6 years, 8 months ago by brettw

Modified:
6 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 260949 "Move gtest/gmock BUILD.gn files to main tree." > Move gtest/gmock BUILD.gn files to main tree. > > Also moves the "unused variable warning" to a config in the build directory so > it can be shared with outher targets without duplication on the command line. > > BUG= > R=cjhopman@chromium.org > > Review URL: https://codereview.chromium.org/219433005 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260954

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-2 lines, -142 lines)			Patch
M	trunk/src/build/config/win/BUILD.gn	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	trunk/src/testing/gmock/BUILD.gn	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	trunk/src/testing/gtest/BUILD.gn	View	1 chunk	+0 lines, -85 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/testing/gmock/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/tools/gn/secondary/testing/gtest/BUILD.gn	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

brettw

6 years, 8 months ago (2014-04-01 22:03:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r260954 (tree was closed).