Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218493013: Use NewScriptState in MIDIAccessResolver, CustomElementLifecycleCallbacks and V8MutationCallbacks (Closed)

Created:
6 years, 8 months ago by haraken
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Use NewScriptState in MIDIAccessResolver, CustomElementLifecycleCallbacks and V8MutationCallbacks We're incrementally replacing RefPtr<DOMWrapperWorld> with RefPtr<NewScriptState>. See the bug description for more details. BUG=357144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -53 lines) Patch
M Source/bindings/v8/MIDIAccessResolver.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/bindings/v8/MIDIAccessResolver.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 7 chunks +31 lines, -29 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/v8/V8PerContextData.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/bindings/v8/V8PerContextData.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
haraken
PTAL
6 years, 8 months ago (2014-04-01 09:02:10 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-01 11:23:42 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-01 11:24:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/218493013/1
6 years, 8 months ago (2014-04-01 11:24:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 12:42:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-01 12:42:57 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 8 months ago (2014-04-01 13:06:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/218493013/1
6 years, 8 months ago (2014-04-01 13:06:15 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 14:18:35 UTC) #9
Message was sent while issue was closed. 
Change committed as 170567

Powered by Google App Engine
This is Rietveld 408576698