Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 218493009: WebRTC+libyuv: switch to use_allocator GYP variable. (Closed)

Created:
6 years, 8 months ago by kjellander_chromium
Modified:
6 years, 8 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

WebRTC+libyuv: switch to use_allocator GYP variable. Use of linux_use_tcmalloc=0 is about to be deprecated and should be replace with use_allocator=none. See https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/2BONW-Xd19c/discussion for more info. This CL also removes pointless use of this variable for Mac and a no-longer-needed use of GYP_GENERATORS=ninja. BUG=345554 TEST=local Mac and Linux builds passing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260791

Patch Set 1 #

Total comments: 4

Patch Set 2 : Made all bots use release_extra_cflags=-g #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M masters/master.client.libyuv/master_builders_cfg.py View 3 chunks +4 lines, -5 lines 0 comments Download
M masters/master.client.webrtc.fyi/master_linux_cfg.py View 1 2 chunks +3 lines, -4 lines 0 comments Download
M masters/master.client.webrtc/master_linux_cfg.py View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.webrtc/master_mac_cfg.py View 1 chunk +4 lines, -5 lines 0 comments Download
M masters/master.tryserver.libyuv/master.cfg View 3 chunks +4 lines, -3 lines 0 comments Download
M masters/master.tryserver.webrtc/master.cfg View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kjellander_chromium
6 years, 8 months ago (2014-03-31 20:27:05 UTC) #1
phoglund_chromium
lgtm, though heads up that the release_extra_cflags are different in some places. https://codereview.chromium.org/218493009/diff/1/masters/master.client.webrtc.fyi/master_linux_cfg.py File masters/master.client.webrtc.fyi/master_linux_cfg.py ...
6 years, 8 months ago (2014-04-01 07:08:06 UTC) #2
kjellander_chromium
Thanks. I looked into the details and changed all to use -g. https://codereview.chromium.org/218493009/diff/1/masters/master.client.webrtc.fyi/master_linux_cfg.py File masters/master.client.webrtc.fyi/master_linux_cfg.py ...
6 years, 8 months ago (2014-04-01 08:16:07 UTC) #3
kjellander_chromium
The CQ bit was checked by kjellander@chromium.org
6 years, 8 months ago (2014-04-01 08:16:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/218493009/20001
6 years, 8 months ago (2014-04-01 08:16:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 08:17:30 UTC) #6
commit-bot: I haz the power
Presubmit check for 218493009-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-01 08:17:31 UTC) #7
kjellander_chromium
The CQ bit was checked by kjellander@chromium.org
6 years, 8 months ago (2014-04-01 08:28:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/218493009/20001
6 years, 8 months ago (2014-04-01 08:28:25 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 08:29:25 UTC) #10
Message was sent while issue was closed.
Change committed as 260791

Powered by Google App Engine
This is Rietveld 408576698