Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 218493007: Perform the illegal redeclaration check earlier in graph building. (Closed)

Created:
6 years, 8 months ago by Jarin
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

We should perform the illegal redeclaration check earlier so that we do not confuse the AST typer with missing type feedback nodes. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/compiler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-handle-illegal-redeclaration.js View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 8 months ago (2014-03-31 13:04:36 UTC) #1
Yang
lgtm.
6 years, 8 months ago (2014-03-31 13:05:51 UTC) #2
Jarin
6 years, 8 months ago (2014-03-31 16:45:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20368 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698