Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 2184913006: chrome/common: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/common: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=dsinclair, jochen BUG=554600 Committed: https://crrev.com/4e388dd146895127c51b881fdbbdcf524e2a90f9 Cr-Commit-Position: refs/heads/master@{#408718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/chrome_content_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/trace_event_args_whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
vmpstr
Please take a look. +dsinclair for tracing +jochen for chrome_content_client.cc. I can't find a closer ...
4 years, 4 months ago (2016-07-28 22:23:09 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-29 09:38:58 UTC) #6
dsinclair
lgtm
4 years, 4 months ago (2016-07-29 13:09:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184913006/1
4 years, 4 months ago (2016-07-29 18:37:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 19:23:00 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 19:25:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e388dd146895127c51b881fdbbdcf524e2a90f9
Cr-Commit-Position: refs/heads/master@{#408718}

Powered by Google App Engine
This is Rietveld 408576698