Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

Issue 2184913005: Add calls to the server to request WebAPK updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WebAPK no longer owns a ManifestUpgradeDetector and rebase on "worker thread" CL. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
index 4bb7346ae9ede2d7278f30e5dd9fb13193c26c48..1996ae8e9dfe19aa06beab5c1a28167f6f2a5b81 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java
@@ -72,8 +72,9 @@ public class ManifestUpgradeDetectorTest {
public boolean mCompleted;
private FetchedData mFetchedData;
- public TestManifestUpgradeDetector(Tab tab, WebappInfo info, FetchedData fetchedData) {
- super(tab, info);
+ public TestManifestUpgradeDetector(Tab tab, WebappInfo info, FetchedData fetchedData,
+ ManifestUpgradeDetector.CheckIfUpgradeNeededCallback callback) {
+ super(tab, info, callback);
mFetchedData = fetchedData;
}
@@ -99,11 +100,6 @@ public class ManifestUpgradeDetectorTest {
}
@Override
- protected void upgrade() {
- mIsUpgraded = true;
pkotwicz 2016/08/11 22:02:44 Doesn't |mIsUpgraded| need to be set to true in th
- }
-
- @Override
protected void onComplete() {
mCompleted = true;
}
@@ -123,7 +119,12 @@ public class ManifestUpgradeDetectorTest {
WEBAPK_NAME, WEBAPK_SHORT_NAME, WEBAPK_DISPLAY_MODE, WEBAPK_ORIENTATION, 0,
WEBAPK_THEME_COLOR, WEBAPK_BACKGROUND_COLOR, false, WEBAPK_PACKAGE_NAME,
WEBAPK_MANIFEST_URL);
- return new TestManifestUpgradeDetector(null, webappInfo, fetchedData);
+ return new TestManifestUpgradeDetector(null, webappInfo, fetchedData,
+ new ManifestUpgradeDetector.CheckIfUpgradeNeededCallback() {
+ @Override
+ public void onCheckIfUpdateNeededFinished(boolean isUpgraded,
+ WebappInfo newInfo) {}
+ });
}
private void setMetaData(String startUrl) {

Powered by Google App Engine
This is Rietveld 408576698