Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2184913005: Add calls to the server to request WebAPK updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: WebAPK no longer owns a ManifestUpgradeDetector and rebase on "worker thread" CL. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index 7c4a070defd51917c2f13376bbf5e96ed1f2895e..7016532e0ffe2f4010eae8e0237fe83bd16bc5f2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -27,9 +27,8 @@ import org.chromium.webapk.lib.client.WebApkServiceConnectionManager;
* UI-less Chrome.
*/
public class WebApkActivity extends WebappActivity {
- /** Detects whether the associated Web Manifest changes. */
- private ManifestUpgradeDetector mManifestUpgradeDetector = null;
-
+ /** Manages whether to check update for the WebAPK, and starts update check if needed. */
+ private WebApkUpdateManager mUpdateManager;
@Override
protected void onNewIntent(Intent intent) {
super.onNewIntent(intent);
@@ -146,15 +145,11 @@ public class WebApkActivity extends WebappActivity {
}
@Override
- public void finishNativeInitialization() {
- super.finishNativeInitialization();
+ public void onDeferredStartup() {
+ super.onDeferredStartup();
- // TODO(hanxi): Ask WebApk's update manager whether to check resource updates.
- if (mManifestUpgradeDetector == null) {
- mManifestUpgradeDetector =
- new ManifestUpgradeDetector(getActivityTab(), mWebappInfo);
- }
- mManifestUpgradeDetector.start();
+ mUpdateManager = new WebApkUpdateManager();
+ mUpdateManager.checkIfUpdateNeeded(getActivityTab(), mWebappInfo);
pkotwicz 2016/08/11 22:02:43 Nit: The method name is deceiving. This method not
Xi Han 2016/08/15 21:38:44 Done.
}
@Override
@@ -182,8 +177,8 @@ public class WebApkActivity extends WebappActivity {
@Override
protected void onDestroyInternal() {
- if (mManifestUpgradeDetector != null) {
- mManifestUpgradeDetector.destroy();
+ if (mUpdateManager != null) {
+ mUpdateManager.destroy();
}
super.onDestroyInternal();
}

Powered by Google App Engine
This is Rietveld 408576698