Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2184913005: Add calls to the server to request WebAPK updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and pkotwicz@'s comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index 7c4a070defd51917c2f13376bbf5e96ed1f2895e..1f02e8aa01cd9a6aceedf7515cc97283f0bac24b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -146,15 +146,13 @@ public class WebApkActivity extends WebappActivity {
}
@Override
- public void finishNativeInitialization() {
- super.finishNativeInitialization();
-
- // TODO(hanxi): Ask WebApk's update manager whether to check resource updates.
+ public void onDeferredStartup() {
+ super.onDeferredStartup();
if (mManifestUpgradeDetector == null) {
Yaron 2016/08/10 02:26:28 It's a little strange the the activity news up a M
Xi Han 2016/08/11 19:01:13 As discussed offline, adopted the above solution.
mManifestUpgradeDetector =
new ManifestUpgradeDetector(getActivityTab(), mWebappInfo);
}
- mManifestUpgradeDetector.start();
+ WebApkUpdateManager.checkUpdate(mWebappInfo.id(), mManifestUpgradeDetector);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698