Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3079)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

Issue 2184913005: Add calls to the server to request WebAPK updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
index 3b3efda710ec17764bc66f490af9e8eed63d49c7..61ddd014934523a5cd9c140512a10a2c762e0ce0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java
@@ -51,6 +51,11 @@ public class ManifestUpgradeDetector extends EmptyTabObserver {
public ManifestUpgradeDetector(Tab tab, WebappInfo info) {
mTab = tab;
mWebappInfo = info;
+ getMetaDataFromAndroidManifest();
+ }
+
+ WebappInfo getWebappInfo() {
+ return mWebappInfo;
}
@VisibleForTesting
@@ -73,8 +78,6 @@ public class ManifestUpgradeDetector extends EmptyTabObserver {
}
if (mNativePointer != 0) return;
-
- getMetaDataFromAndroidManifest();
mNativePointer = nativeInitialize(mTab.getWebContents(),
mWebappInfo.scopeUri().toString(), mWebappInfo.webManifestUri().toString());
@@ -173,7 +176,9 @@ public class ManifestUpgradeDetector extends EmptyTabObserver {
return false;
}
- private void upgrade() {}
+ private void upgrade() {
+ WebApkUpdateManager.updateAsync(mWebappInfo);
pkotwicz 2016/08/03 01:07:06 Shouldn't you call WebApkUpdateManager with the ne
Xi Han 2016/08/03 17:30:04 Discussed with Glen, yes, we need to send the new
+ }
private native long nativeInitialize(WebContents webContents, String scope,
String webManifestUrl);

Powered by Google App Engine
This is Rietveld 408576698