Add calls to the server to request WebAPK updates.

chrome/browser/android/webapk/webapk_installer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INSTALLER_H_
 #define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INSTALLER_H_
 
 #include <jni.h>
 #include <memory>
 
 #include "base/android/scoped_java_ref.h"
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/android/shortcut_info.h"
 #include "chrome/browser/net/file_downloader.h"
+#include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace base {
 class FilePath;
 }
 
 namespace content {
 class BrowserContext;
 }
 
-namespace net {
-class URLFetcher;
-class URLRequestContextGetter;
-}
-
 namespace webapk {
 class WebApk;
 }
 
 // Talks to Chrome WebAPK server and Google Play to generate a WebAPK on the
 // server, download it, and install it.
 class WebApkInstaller : public net::URLFetcherDelegate {
  public:
+  // Called when either a request of creating or updating WebAPK has been sent
+  // or the creation process of the WebAPK on the server side fails.
+  // Parameters:
+  // - whether the request succeeds.

[pkotwicz, 2016/08/09 14:35:43]

How about:
"Called when either a request for creating/updating a WebAPK has been sent to
Google Play or the create/update process fails.
Parameters:
- whether the request succeeds."

I think that my version makes it clearer what "or" is referring to.

[Xi Han, 2016/08/11 19:01:15]

Done.

   using FinishCallback = base::Callback<void(bool)>;
 
   WebApkInstaller(const ShortcutInfo& shortcut_info,
                   const SkBitmap& shorcut_icon);
+
   ~WebApkInstaller() override;
 
   // Talks to the Chrome WebAPK server to generate a WebAPK on the server and to
   // Google Play to install the generated WebAPK. Calls |callback| after the
   // request to install the WebAPK is sent to Google Play.
   void InstallAsync(content::BrowserContext* browser_context,
                     const FinishCallback& callback);
 
   // Same as InstallAsync() but uses the passed in |request_context_getter|.
   void InstallAsyncWithURLRequestContextGetter(
       net::URLRequestContextGetter* request_context_getter,
       const FinishCallback& callback);
 
+  // Talks to the Chrome WebAPK server to update a WebAPK on the server and to
+  // the Google Play server to download and install the generated WebAPK. Calls
+  // |callback| after the request to download and install the WebAPK is sent to
+  // the Google Play server.
+  void UpdateAsync(content::BrowserContext* browser_context,
+                   const FinishCallback& callback,
+                   const std::string& webapk_package,
+                   int version);
+
   // Sets the timeout for the server requests.
   void SetTimeoutMs(int timeout_ms);
 
  protected:
   // Starts installation of the downloaded WebAPK. Returns whether the install
   // could be started. The installation may still fail if true is returned.
   // |file_path| is the file path that the WebAPK was downloaded to.
   // |package_name| is the package name that the WebAPK should be installed at.
   virtual bool StartDownloadedWebApkInstall(
       JNIEnv* env,
       const base::android::ScopedJavaLocalRef<jstring>& java_file_path,
       const base::android::ScopedJavaLocalRef<jstring>& java_package_name);
 
  private:
+  enum TaskType {
+    UNDEFINED,
+    INSTALL,
+    UPDATE,
+  };
+
   // net::URLFetcherDelegate:
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   // Initializes |request_context_getter_| on UI thread.
   void InitializeRequestContextGetterOnUIThread(
       content::BrowserContext* browser_context);
 
-  // Sends request to WebAPK server to create WebAPK. During a successful
-  // request the WebAPK server responds with the URL of the generated WebAPK.
+  // Sends request to WebAPK server to create WebAPK.
   void SendCreateWebApkRequest();
 
+  // Sends request to WebAPK server to update a WebAPK.
+  void SendUpdateWebApkRequest();
+
+  // Sends a request to WebAPK server. During a successful request the
+  // WebAPK server responds with a URL to send to Google Play to
+  // download and install the generated WebAPK.

[pkotwicz, 2016/08/09 14:35:43]

Nit: The comment is incorrect. WebApkInstaller does the download not Google
Play.

How about: "Sends a request to WebAPK server to create/update WebAPK. During a
successful request the WebAPK server responds with the URL of the generated
WebAPK."

[Xi Han, 2016/08/11 19:01:15]

Done.

+  void SendRequest(
+      std::unique_ptr<webapk::WebApk> request_proto,
+      net::URLFetcher::RequestType request_type,
+      const GURL& server_url);
+
   // Called with the URL of generated WebAPK and the package name that the
   // WebAPK should be installed at.
   void OnGotWebApkDownloadUrl(const GURL& download_url,
                               const std::string& package_name);
 
   // Called once the WebAPK has been downloaded. Installs the WebAPK if the
   // download was successful.
   // |file_path| is the file path that the WebAPK was downloaded to.
   // |package_name| is the package name that the WebAPK should be installed at.
   void OnWebApkDownloaded(const base::FilePath& file_path,
@@ skipping 40 matching lines @@
   // WebAPK server URL.
   GURL server_url_;
 
   // The number of milliseconds to wait for the WebAPK download URL from the
   // WebAPK server.
   int webapk_download_url_timeout_ms_;
 
   // The number of milliseconds to wait for the WebAPK download to complete.
   int download_timeout_ms_;
 
+  // WebAPK package name.
+  std::string webapk_package_;
+
+  // WebAPK version code.
+  int webapk_version_;
+
+  // A flag to indicate whether the installer is for installing or updating a
+  // WebAPK.

[pkotwicz, 2016/08/09 14:35:43]

How about: "Indicates whether the installer ..."

My version is shorter :)

[Xi Han, 2016/08/11 19:01:15]

Done.

+  TaskType task_type_;
+
   // Used to get |weak_ptr_| on the IO thread.
   base::WeakPtrFactory<WebApkInstaller> io_weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebApkInstaller);
 };
 
 #endif  // CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INSTALLER_H_