Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 syntax = "proto2"; | 5 syntax = "proto2"; |
| 6 | 6 |
| 7 option optimize_for = LITE_RUNTIME; | 7 option optimize_for = LITE_RUNTIME; |
| 8 | 8 |
| 9 package webapk; | 9 package webapk; |
| 10 | 10 |
| 11 // Creates a WebAPK on the server and returns URL to download WebAPK from Google | 11 // Creates a WebAPK on the server and returns URL to download WebAPK from Google |
| 12 // Play. | 12 // Play. |
| 13 message CreateWebApkRequest { | 13 message CreateWebApkRequest { |
| 14 optional WebApk webapk = 1; | 14 optional WebApk webapk = 1; |
| 15 } | 15 } |
| 16 | 16 |
| 17 // Response to CreateWebApkRequest. | 17 // Creates a updated WebAPK on the server and returns URL to download WebAPK |
| 18 message CreateWebApkResponse { | 18 // from Google Play. |
| 19 message UpdateWebApkRequest { | |
| 20 optional WebApk webapk = 1; | |
| 21 } | |
| 22 | |
| 23 // Response after creating or updating a WebAPK. | |
| 24 message WebApkResponse { | |
|
pkotwicz
2016/08/02 21:05:04
I think that we should either:
- Have a different
Xi Han
2016/08/03 17:30:05
As discussed offline, just keep the proto the same
| |
| 19 // Package name to install WebAPK at. | 25 // Package name to install WebAPK at. |
| 20 optional string webapk_package_name = 1; | 26 optional string webapk_package_name = 1; |
| 21 | 27 |
| 22 // URL to download WebAPK. | 28 // Version code of the WebAPK. |
| 23 optional string signed_download_url = 2; | 29 optional string version = 2; |
| 30 | |
| 31 // URL to download WebAPK from Google Play. | |
| 32 optional string signed_market_url = 5; | |
|
pkotwicz
2016/08/03 01:07:06
In the new world, Chrome is responsible for downlo
Xi Han
2016/08/03 17:30:05
Done.
| |
| 33 | |
| 34 // Warnings regarding the creation or update of the WebAPK, if any. | |
| 35 repeated string warnings = 4; | |
|
pkotwicz
2016/08/03 01:07:06
We do not seem to be using this field. Let's skip
Xi Han
2016/08/03 17:30:04
Done.
| |
| 24 } | 36 } |
| 25 | 37 |
| 26 message WebApk { | 38 message WebApk { |
| 39 // Package name of the WebAPK. | |
| 40 optional string package_name = 1; | |
| 41 | |
| 42 // Version code of the WebAPK. | |
| 43 optional string version = 2; | |
|
pkotwicz
2016/08/02 21:05:04
You do not seem to send this field in webapk_insta
Xi Han
2016/08/03 17:30:05
Good catch, added.
| |
| 44 | |
| 27 // The URL of the Web App Manifest. | 45 // The URL of the Web App Manifest. |
| 28 optional string manifest_url = 2; | 46 optional string manifest_url = 3; |
| 29 | 47 |
| 30 // Chrome's package name. | 48 // Chrome's package name. |
| 31 optional string requester_application_package = 4; | 49 optional string requester_application_package = 5; |
| 32 | 50 |
| 33 // Chrome's version. | 51 // Chrome's version. |
| 34 optional string requester_application_version = 5; | 52 optional string requester_application_version = 6; |
| 35 | 53 |
| 36 // The Web App Manifest. | 54 // The Web App Manifest. |
| 37 optional WebAppManifest manifest = 6; | 55 optional WebAppManifest manifest = 7; |
| 38 | 56 |
| 39 reserved 1, 3, 7; | 57 reserved 4; |
| 40 } | 58 } |
| 41 | 59 |
| 42 // Contains data from the Web App Manifest. | 60 // Contains data from the Web App Manifest. |
| 43 message WebAppManifest { | 61 message WebAppManifest { |
| 44 optional string name = 1; | 62 optional string name = 1; |
| 45 optional string short_name = 2; | 63 optional string short_name = 2; |
| 46 optional string start_url = 4; | 64 optional string start_url = 4; |
| 47 repeated string scopes = 5; | 65 repeated string scopes = 5; |
| 48 repeated Image icons = 6; | 66 repeated Image icons = 6; |
| 49 optional string orientation = 9; | 67 optional string orientation = 9; |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 61 // MD5 hash of the icon's bytes. There should not be any transformations | 79 // MD5 hash of the icon's bytes. There should not be any transformations |
| 62 // applied to the icon's bytes prior to taking the MD5 hash. | 80 // applied to the icon's bytes prior to taking the MD5 hash. |
| 63 optional string hash = 5; | 81 optional string hash = 5; |
| 64 | 82 |
| 65 // Actual bytes of the image. This image may be re-encoded from the original | 83 // Actual bytes of the image. This image may be re-encoded from the original |
| 66 // image and may not match the MD5 hash field above. | 84 // image and may not match the MD5 hash field above. |
| 67 optional bytes image_data = 6; | 85 optional bytes image_data = 6; |
| 68 | 86 |
| 69 reserved 2 to 4; | 87 reserved 2 to 4; |
| 70 } | 88 } |
| OLD | NEW |