Issue 2184903002: Fix profiler access to the Dart stack pointer on ARM64.

Issue 2184903002: Fix profiler access to the Dart stack pointer on ARM64. (Closed)

Created:
4 years, 4 months ago by rmacnak

Modified:
4 years, 4 months ago

Reviewers:
Florian Schneider, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix profiler access to the Dart stack pointer on ARM64. Cf. 642f75421976e0f19ce21ca17cc6226f75871eab. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d4e1f1364424367346d2dbf1f4bb51966cb6e674

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -15 lines)			Patch
M	runtime/vm/signal_handler_android.cc	View	1	2 chunks	+5 lines, -13 lines	0 comments	Download
M	runtime/vm/signal_handler_linux.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/signal_handler_macos.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 8 (3 generated)

Cutch

LGTM if you use a #define MACRO and add a COMPILE_ASSERT that will blow up ...

4 years, 4 months ago (2016-07-26 23:03:42 UTC) #4

rmacnak

Flipped the style used by the Android case and used the SPREG constant. PTAL.

4 years, 4 months ago (2016-07-26 23:42:33 UTC) #5

rmacnak

4 years, 4 months ago (2016-07-26 23:59:22 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d4e1f1364424367346d2dbf1f4bb51966cb6e674 (presubmit successful).