Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2467)

Unified Diff: chrome/test/data/webui/settings/settings_menu_test.js

Issue 2184893002: Settings Router Refactor: Remove route.page legacy property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0217-settings-refactor-settings-menu
Patch Set: fix contains issue. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index 727a667ae395e71c02357621ad8f08aac9c18bcc..0e6da83e5caccf6125dc935911dd147d52217241 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -12,9 +12,7 @@ cr.define('settings_menu', function() {
setup(function() {
PolymerTest.clearBody();
settingsMenu = document.createElement('settings-menu');
- settingsMenu.currentRoute = {
- page: 'basic', section: '', subpage: []
- };
+ settingsMenu.currentRoute = settings.Route.BASIC;
document.body.appendChild(settingsMenu);
});
@@ -44,11 +42,9 @@ cr.define('settings_menu', function() {
});
test('openResetSection', function() {
- settingsMenu.currentRoute = {
- page: 'advanced', section: 'reset', subpage: []
- };
+ settingsMenu.currentRoute = settings.Route.RESET;
var advancedPage = settingsMenu.$.advancedPage;
- assertEquals('reset',
+ assertEquals('/reset',
advancedPage.querySelector('paper-menu').selected);
});
});

Powered by Google App Engine
This is Rietveld 408576698