chrome/browser/resources/settings/settings_page/main_page_behavior.js - Issue 2184893002: Settings Router Refactor: Remove route.page legacy property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2184893002: Settings Router Refactor: Remove route.page legacy property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0217-settings-refactor-settings-menu

Patch Set: fix contains issue. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_menu/settings_menu.html ('K') | « chrome/browser/resources/settings/settings_menu/settings_menu.js ('k') | chrome/browser/resources/settings/settings_page/settings_router.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js

diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

index 933a0ec4baab3a6cd5c57404141fed70b549de6c..852386f78c37e9ceec28fb565ba4fbb47228c13b 100644

--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js

+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js

@@ -407,10 +407,9 @@ var RoutableBehaviorImpl = {

this.collapseSection(section);

}

- if (newRoute && newRoute.section &&

- this.$$('[data-page=' + newRoute.page + ']')) {

+ // Scrolls to the section if this main page contains the route's section.

+ if (newRoute && newRoute.section && this.getSection_(newRoute.section))

this.scrollToSection_();

- }

}