Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 2184893002: Settings Router Refactor: Remove route.page legacy property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0217-settings-refactor-settings-menu
Patch Set: fix contains issue. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="/appearance_page/appearance_page.html"> 2 <link rel="import" href="/appearance_page/appearance_page.html">
3 <link rel="import" href="/search_page/search_page.html"> 3 <link rel="import" href="/search_page/search_page.html">
4 <link rel="import" href="/settings_page/main_page_behavior.html"> 4 <link rel="import" href="/settings_page/main_page_behavior.html">
5 <link rel="import" href="/settings_page/settings_page_visibility.html"> 5 <link rel="import" href="/settings_page/settings_page_visibility.html">
6 <link rel="import" href="/settings_page/settings_router.html"> 6 <link rel="import" href="/settings_page/settings_router.html">
7 <link rel="import" href="/settings_page/settings_section.html"> 7 <link rel="import" href="/settings_page/settings_section.html">
8 <link rel="import" href="/on_startup_page/on_startup_page.html"> 8 <link rel="import" href="/on_startup_page/on_startup_page.html">
9 <link rel="import" href="/people_page/people_page.html"> 9 <link rel="import" href="/people_page/people_page.html">
10 <link rel="import" href="/reset_page/reset_profile_banner.html"> 10 <link rel="import" href="/reset_page/reset_profile_banner.html">
11 <link rel="import" href="/settings_page_css.html"> 11 <link rel="import" href="/settings_page_css.html">
12 12
13 <if expr="chromeos"> 13 <if expr="chromeos">
14 <link rel="import" href="/device_page/device_page.html"> 14 <link rel="import" href="/device_page/device_page.html">
15 <link rel="import" href="/internet_page/internet_page.html"> 15 <link rel="import" href="/internet_page/internet_page.html">
16 </if> 16 </if>
17 17
18 <if expr="not chromeos"> 18 <if expr="not chromeos">
19 <link rel="import" href="/default_browser_page/default_browser_page.html"> 19 <link rel="import" href="/default_browser_page/default_browser_page.html">
20 </if> 20 </if>
21 21
22 <dom-module id="settings-basic-page"> 22 <dom-module id="settings-basic-page">
23 <template> 23 <template>
24 <style include="settings-page-styles"></style> 24 <style include="settings-page-styles"></style>
25 <div data-page="basic"> 25 <div>
26 <template is="dom-if" if="[[showResetProfileBanner_]]"> 26 <template is="dom-if" if="[[showResetProfileBanner_]]">
27 <settings-reset-profile-banner on-reset-done="onResetDone_"> 27 <settings-reset-profile-banner on-reset-done="onResetDone_">
28 </settings-reset-profile-banner> 28 </settings-reset-profile-banner>
29 </template> 29 </template>
30 <if expr="chromeos"> 30 <if expr="chromeos">
31 <template is="dom-if" if="[[showPage(pageVisibility.internet)]]" restamp> 31 <template is="dom-if" if="[[showPage(pageVisibility.internet)]]" restamp>
32 <settings-section page-title="$i18n{internetPageTitle}" 32 <settings-section page-title="$i18n{internetPageTitle}"
33 current-route="[[currentRoute]]" section="internet"> 33 current-route="[[currentRoute]]" section="internet">
34 <settings-internet-page current-route="{{currentRoute}}"> 34 <settings-internet-page current-route="{{currentRoute}}">
35 </settings-internet-page> 35 </settings-internet-page>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 current-route="[[currentRoute]]" section="onStartup"> 87 current-route="[[currentRoute]]" section="onStartup">
88 <settings-on-startup-page prefs="{{prefs}}" 88 <settings-on-startup-page prefs="{{prefs}}"
89 current-route="{{currentRoute}}"> 89 current-route="{{currentRoute}}">
90 </settings-on-startup-page> 90 </settings-on-startup-page>
91 </settings-section> 91 </settings-section>
92 </template> 92 </template>
93 </div> 93 </div>
94 </template> 94 </template>
95 <script src="basic_page.js"></script> 95 <script src="basic_page.js"></script>
96 </dom-module> 96 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698