Settings Router Refactor: Remove route.page legacy property.

chrome/browser/resources/settings/device_page/device_page.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-device-page' is the settings page for device and
  * peripheral settings.
  */
 Polymer({
   is: 'settings-device-page',
@@ skipping 111 matching lines @@
    * @private
    */
   checkPointerSubpage_: function() {
     if (!this.hasMouse_ && !this.hasTouchpad_ &&
         this.isCurrentRouteOnPointersPage_()) {
       this.$.pages.fire('subpage-back');
     }
   },
 
   /**
    * TODO(michaelpg): create generic fn for this and isCurrentRouteOnSyncPage_.

[michaelpg, 2016/07/28 23:22:31]

see next comment: delete isCurrentRouteOnSyncPage_

[tommycli, 2016/07/29 00:03:35]

Done.

    * @return {boolean} Whether the current route shows the pointers page.
    * @private
    */
   isCurrentRouteOnPointersPage_: function() {
-    return this.currentRoute &&
-        this.currentRoute.page == 'basic' &&
-        this.currentRoute.section == 'device' &&
-        this.currentRoute.subpage.length == 1 &&
-        this.currentRoute.subpage[0] == 'pointers';
+    return this.currentRoute == settings.Route.POINTERS;

[michaelpg, 2016/07/28 23:22:31]

meh, optionally: just inline this -- it's literally the same as the function
name, and device_page_tests.js doesn't need to use it since it knows the route
too

[tommycli, 2016/07/29 00:03:35]

Done.

   },
 });