runtime/observatory/lib/src/elements/nav/notify_wrapper.dart - Issue 2184873002: Removed dynamic Symbol creation and marked Bindable classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/nav/notify_wrapper.dart

Issue 2184873002: Removed dynamic Symbol creation and marked Bindable classes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/nav/notify_wrapper.dart

diff --git a/runtime/observatory/lib/src/elements/nav/notify_wrapper.dart b/runtime/observatory/lib/src/elements/nav/notify_wrapper.dart

index 97f4ded559c9776d321322447fc3c1c90517fe6b..76767278c14b5ac98bcbda1bcb823e0dad6f1fa0 100644

--- a/runtime/observatory/lib/src/elements/nav/notify_wrapper.dart

+++ b/runtime/observatory/lib/src/elements/nav/notify_wrapper.dart

@@ -10,9 +10,11 @@ import 'package:observatory/src/elements/helpers/tag.dart';

import 'package:observatory/src/elements/shims/binding.dart';

import 'package:observatory/src/elements/nav/notify.dart';

+@bindable

class NavNotifyElementWrapper extends HtmlElement {

- static final binder = new Binder<NavNotifyElementWrapper>(

- const [const Binding('notifications'), const Binding('notifyOnPause')]);

+ static const binder = const Binder<NavNotifyElementWrapper>(const {

+ 'notifications': #notifications, 'notifyOnPause': #notifyOnPause

+ });

static const tag = const Tag<NavNotifyElementWrapper>('nav-notify');