Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart

Issue 2184873002: Removed dynamic Symbol creation and marked Bindable classes (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:async'; 6 import 'dart:async';
7 7
8 import 'package:observatory/app.dart'; 8 import 'package:observatory/app.dart';
9 import 'package:observatory/mocks.dart'; 9 import 'package:observatory/mocks.dart';
10 import 'package:observatory/models.dart' as M; 10 import 'package:observatory/models.dart' as M;
11 import 'package:observatory/service.dart'; 11 import 'package:observatory/service.dart';
12 import 'package:observatory/service_common.dart'; 12 import 'package:observatory/service_common.dart';
13 import 'package:observatory/src/elements/helpers/tag.dart'; 13 import 'package:observatory/src/elements/helpers/tag.dart';
14 import 'package:observatory/src/elements/shims/binding.dart'; 14 import 'package:observatory/src/elements/shims/binding.dart';
15 import 'package:observatory/src/elements/nav/vm_menu.dart'; 15 import 'package:observatory/src/elements/nav/vm_menu.dart';
16 16
17 @bindable
17 class NavVMMenuElementWrapper extends HtmlElement { 18 class NavVMMenuElementWrapper extends HtmlElement {
18 static final binder = new Binder<NavVMMenuElementWrapper>( 19 static const binder = const Binder<NavVMMenuElementWrapper>(const {
19 const [const Binding('last'), const Binding('vm')]); 20 'last': #last, 'vm': #vm
21 });
20 22
21 static const tag = const Tag<NavVMMenuElementWrapper>('vm-nav-menu'); 23 static const tag = const Tag<NavVMMenuElementWrapper>('vm-nav-menu');
22 24
23 StreamSubscription _subscription; 25 StreamSubscription _subscription;
24 StreamController<M.VMUpdateEvent> _updatesController = 26 StreamController<M.VMUpdateEvent> _updatesController =
25 new StreamController<M.VMUpdateEvent>.broadcast(); 27 new StreamController<M.VMUpdateEvent>.broadcast();
26 28
27 bool _last = false; 29 bool _last = false;
28 VM _vm; 30 VM _vm;
29 bool get last => _last; 31 bool get last => _last;
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 queue: ObservatoryApplication.app.queue) 82 queue: ObservatoryApplication.app.queue)
81 ..children = [new ContentElement()] 83 ..children = [new ContentElement()]
82 ]; 84 ];
83 } 85 }
84 86
85 bool _getBoolAttribute(String name) { 87 bool _getBoolAttribute(String name) {
86 final String value = getAttribute(name); 88 final String value = getAttribute(name);
87 return !(value == null || value == 'false'); 89 return !(value == null || value == 'false');
88 } 90 }
89 } 91 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698