Serialize SkColorSpace into DeferredTextureImage

Serialize SkColorSpace into DeferredTextureImage

This fixes a memory leak that occurs when DeferredTextureImage is deallocated without being destroyed. It is intended to be stored in discarable memory and thus this has to be safe.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010

Committed: https://skia.googlesource.com/skia/+/4d516a6903d83414b5615ca9388b52064da6990c

[bsalomon, 2016-07-28 18:42:14]

Description was changed from

==========
Serialize SkColorSpace into DeferredTextureImage
==========

to

==========
Serialize SkColorSpace into DeferredTextureImage
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010
==========

[bsalomon, 2016-07-28 18:50:26]

bsalomon@google.com changed reviewers:
+ msarett@google.com, robertphillips@google.com

[bsalomon, 2016-07-28 18:51:34]

Description was changed from

==========
Serialize SkColorSpace into DeferredTextureImage
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010
==========

to

==========
Serialize SkColorSpace into DeferredTextureImage

This fixes a memory leak that occurs when DeferredTextureImage is deallocated
without being destroyed. It is intended to be stored in discarable memory and
thus this has to be safe.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010
==========

[msarett, 2016-07-28 18:58:39]

lgtm

[bsalomon, 2016-07-28 18:58:56]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 18:58:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-07-28 19:09:56]

lgtm

https://codereview.chromium.org/2184823010/diff/60001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/2184823010/diff/60001/src/image/SkImage_Gpu.c...
src/image/SkImage_Gpu.cpp:366: struct DeferredTextureImage {
lien this guy up with the rest ?

[commit-bot: I haz the power, 2016-07-28 19:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 19:46:07]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-07-28 19:51:29]

https://codereview.chromium.org/2184823010/diff/60001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/2184823010/diff/60001/src/image/SkImage_Gpu.c...
src/image/SkImage_Gpu.cpp:366: struct DeferredTextureImage {
On 2016/07/28 19:09:56, robertphillips wrote:
> lien this guy up with the rest ?

Done.

[bsalomon, 2016-07-28 19:51:32]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-07-28 19:51:32]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2184823010/#ps80001
(title: "whitespace")

[commit-bot: I haz the power, 2016-07-28 19:51:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 20:37:36]

Description was changed from

==========
Serialize SkColorSpace into DeferredTextureImage

This fixes a memory leak that occurs when DeferredTextureImage is deallocated
without being destroyed. It is intended to be stored in discarable memory and
thus this has to be safe.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010
==========

to

==========
Serialize SkColorSpace into DeferredTextureImage

This fixes a memory leak that occurs when DeferredTextureImage is deallocated
without being destroyed. It is intended to be stored in discarable memory and
thus this has to be safe.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823010

Committed:
https://skia.googlesource.com/skia/+/4d516a6903d83414b5615ca9388b52064da6990c
==========

[commit-bot: I haz the power, 2016-07-28 20:37:37]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/4d516a6903d83414b5615ca9388b52064da6990c