Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2184823009: Silence -Wclobbered in each file that needs it. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Silence -Wclobbered in each file that needs it. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184823009 Committed: https://skia.googlesource.com/skia/+/03f704a343d7a82974f977eda8789a8c721c93e5 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-GCE-CPU-AVX2-x86-Release-Trybot Committed: https://skia.googlesource.com/skia/+/dc90b53350b9b21a856d2fb1574f9b41ded4f735

Patch Set 1 #

Patch Set 2 : jpeg can be fixed with a new scope #

Patch Set 3 : png strat everywhere #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M gyp/codec.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
mtklein_C
Please consider PS 1 and PS 2 as two separate proposals... I'm happy with either. ...
4 years, 4 months ago (2016-07-28 18:15:19 UTC) #3
msarett
PS2 lgtm Happy with the simple fix for Jpeg. I think disabling is the right ...
4 years, 4 months ago (2016-07-28 18:17:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823009/20001
4 years, 4 months ago (2016-07-28 18:18:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/03f704a343d7a82974f977eda8789a8c721c93e5
4 years, 4 months ago (2016-07-28 18:57:33 UTC) #8
mtklein
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2188313003/ by mtklein@google.com. ...
4 years, 4 months ago (2016-07-28 20:59:54 UTC) #9
msarett
On 2016/07/28 20:59:54, mtklein wrote: > A revert of this CL (patchset #2 id:20001) has ...
4 years, 4 months ago (2016-07-28 21:01:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823009/40001
4 years, 4 months ago (2016-07-28 21:02:04 UTC) #14
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 4 months ago (2016-07-28 21:02:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823009/40001
4 years, 4 months ago (2016-07-28 21:02:44 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:45:31 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/dc90b53350b9b21a856d2fb1574f9b41ded4f735

Powered by Google App Engine
This is Rietveld 408576698