chrome/browser/permissions/permission_context_base.cc - Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary PermissionUtil changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_context_base.h ('k') | chrome/browser/permissions/permission_context_base_unittest.cc » ('j') | chrome/browser/permissions/permission_context_base_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_context_base.cc

diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc

index 8ce7f18b287fe0885a835bc862d313c02bbf2370..284a375c9fbe17c8251c26f179f92fa83f77b004 100644

--- a/chrome/browser/permissions/permission_context_base.cc

+++ b/chrome/browser/permissions/permission_context_base.cc

@@ -216,6 +216,16 @@ void PermissionContextBase::PermissionDecided(

PermissionRequestGestureType gesture_type =

user_gesture ? PermissionRequestGestureType::GESTURE

: PermissionRequestGestureType::NO_GESTURE;

+ // Check if we should convert a dismiss decision into a block decision. This

+ // is gated on enabling the kBlockPromptsIfDismissedOften feature.

+ if (!persist &&

+ prompt_decision_log_.Get().ShouldChangeDismissalToBlock(

+ profile_, requesting_origin, permission_type_)) {

+ persist = true;

+ content_setting = CONTENT_SETTING_BLOCK;

+ }

if (persist) {

DCHECK(content_setting == CONTENT_SETTING_ALLOW ||

content_setting == CONTENT_SETTING_BLOCK);