tools/metrics/histograms/histograms.xml - Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/permissions/permission_context_base_unittest.cc ('K') | « components/content_settings/core/common/content_settings_types.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 7dd4a3842746ee713a6c2e134eb3d2656a10f118..1d986da5b6f59db2d2796263b6b4c7749d22a0c4 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -39505,6 +39505,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Permissions.Prompt.DismissCount">

+ <owner>dominickn@chromium.org</owner>

+ <summary>

+ This metric, recorded at the time of a permission prompt dismissal, records

+ the total number of prompt dismissal events for this origin since the last

+ time the user cleared their history or site data, inclusive of the current

+ dismissal. Every event in a bucket larger than 1 in this histogram will also

+ have an event in each smaller bucket. The suffix of the histogram indicates

+ which particular permission.

+ </summary>

+</histogram>

+<histogram name="Permissions.Prompt.IgnoreCount">

+ <owner>dominickn@chromium.org</owner>

+ <summary>

+ This metric, recorded at the time of a permission prompt ignore, records the

+ total number of prompt ignore events for this origin since the last time the

+ user cleared their history or site data, inclusive of the current ignore.

+ Every event in a bucket larger than 1 in this histogram will also have an

+ event in each smaller bucket. The suffix of the histogram indicates which

+ particular permission.

+ </summary>

+</histogram>

<histogram name="Permissions.Prompt.MergedBubbleAccepted"

enum="PermissionRequestType">

<owner>benwells@chromium.org</owner>

@@ -100484,6 +100508,8 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="Permissions.Action"/>

<affected-histogram name="Permissions.Action.InsecureOrigin"/>

<affected-histogram name="Permissions.Action.SecureOrigin"/>

+ <affected-histogram name="Permissions.Prompt.DismissCount"/>

+ <affected-histogram name="Permissions.Prompt.IgnoreCount"/>

<affected-histogram name="Permissions.Requested.CrossOrigin"/>

</histogram_suffixes>

« chrome/browser/permissions/permission_context_base_unittest.cc ('K') | « components/content_settings/core/common/content_settings_types.h ('k') | no next file » | no next file with comments »