chrome/browser/browsing_data/browsing_data_remover.cc - Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | chrome/browser/permissions/permission_context_base_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc

index 4b4325239d15ea3c876965f2ba3581260327f187..cf73ad4c134a14fae4fa4b4093eef0c4b7799baa 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover.cc

@@ -32,6 +32,7 @@

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"

#include "chrome/browser/password_manager/password_store_factory.h"

+#include "chrome/browser/permissions/permission_decision_auto_blocker.h"

#include "chrome/browser/prerender/prerender_manager.h"

#include "chrome/browser/prerender/prerender_manager_factory.h"

#include "chrome/browser/profiles/profile.h"

@@ -798,6 +799,8 @@ void BrowsingDataRemover::RemoveImpl(

HostContentSettingsMapFactory::GetForProfile(profile_),

CONTENT_SETTINGS_TYPE_APP_BANNER,

base::Bind(&ForwardPrimaryPatternCallback, same_pattern_filter));

+ PermissionDecisionAutoBlocker::RemoveCountsByUrl(profile_, filter);

}

if (remove_mask & REMOVE_PASSWORDS) {