Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index ee69985714e9488e9ed9e9af6eb372a8e6dec8ae..2d58f91bb340cc58f7fd91a5bba05e6da7fdfbef 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -356,6 +356,47 @@ void PermissionUmaUtil::PermissionPromptDenied(
requests[0]->GetGestureType(), requests[0]->GetPermissionRequestType());
}
+void PermissionUmaUtil::PermissionPromptDismissCount(
raymes 2016/08/06 00:50:21 Please get Kendra to take a look at this for the m
dominickn 2016/08/08 02:18:28 Will do.
+ content::PermissionType permission,
+ int count) {
+ switch (permission) {
+ case PermissionType::GEOLOCATION:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.Geolocation", count);
+ break;
+ case PermissionType::NOTIFICATIONS:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.Notifications", count);
+ break;
+ case PermissionType::MIDI_SYSEX:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.MidiSysEx", count);
+ break;
+ case PermissionType::PUSH_MESSAGING:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.PushMessaging", count);
+ break;
+ case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.ProtectedMedia",
+ count);
+ break;
+ case PermissionType::DURABLE_STORAGE:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.DurableStorage",
+ count);
+ break;
+ case PermissionType::AUDIO_CAPTURE:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.AudioCapture", count);
+ break;
+ case PermissionType::VIDEO_CAPTURE:
+ UMA_HISTOGRAM_COUNTS_100("Permissions.DismissCount.VideoCapture", count);
+ break;
+ // The user is not prompted for these permissions, thus there is no dismiss
+ // recorded for them.
+ case PermissionType::MIDI:
+ case PermissionType::BACKGROUND_SYNC:
+ case PermissionType::NUM:
+ NOTREACHED() << "PERMISSION "
+ << PermissionUtil::GetPermissionString(permission)
+ << " not accounted for";
+ }
+}
+
bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnablePermissionActionReporting))

Powered by Google App Engine
This is Rietveld 408576698