tools/metrics/histograms/histograms.xml - Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unify implementation in permission_context_base, make log static Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index daf27f8b2df08bb09fb1f688ce9baab0c31ec5f8..7abcdf8e603f38d0aa7a720bbc1f05c2d1952f93 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -39193,6 +39193,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Permissions.DismissCount">

+ <owner>dominickn@chromium.org</owner>

+ <summary>

+ This metric tracks the total number of prompt dismissal events for an

+ origin, recorded at the time of a prompt dismissal. Repeated dismissals for

+ an origin will record a higher count in this histogram. The suffix of the

+ histogram indicates which particular permission.

+ </summary>

+</histogram>

<owner>benwells@chromium.org</owner>

<owner>tsergeant@chromium.org</owner>

@@ -99835,6 +99845,7 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="Permissions.Action"/>

<affected-histogram name="Permissions.Action.InsecureOrigin"/>

<affected-histogram name="Permissions.Action.SecureOrigin"/>

+ <affected-histogram name="Permissions.DismissCount"/>

<affected-histogram name="Permissions.Requested.CrossOrigin"/>

</histogram_suffixes>

« chrome/browser/permissions/permission_uma_util.cc ('K') | « components/content_settings/core/common/content_settings_types.h ('k') | no next file » | no next file with comments »