chrome/browser/permissions/permission_queue_controller.cc - Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_queue_controller.cc

Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unify implementation in permission_context_base, make log static Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_queue_controller.h ('K') | « chrome/browser/permissions/permission_queue_controller.h ('k') | chrome/browser/permissions/permission_uma_util.h » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_queue_controller.cc

diff --git a/chrome/browser/permissions/permission_queue_controller.cc b/chrome/browser/permissions/permission_queue_controller.cc

index 3382aaadc0e6deedeec7514712f664eb18699061..1e3b15826510a1441af80f27d599a2a0d237d933 100644

--- a/chrome/browser/permissions/permission_queue_controller.cc

+++ b/chrome/browser/permissions/permission_queue_controller.cc

@@ -217,6 +217,7 @@ void PermissionQueueController::OnPermissionSet(const PermissionRequestID& id,

PermissionRequestGestureType gesture_type =

user_gesture ? PermissionRequestGestureType::GESTURE

: PermissionRequestGestureType::NO_GESTURE;

raymes 2016/08/05 03:27:48 nit: remove from this CL

dominickn 2016/08/05 04:29:30 Done.

if (update_content_setting) {

UpdateContentSetting(requesting_frame, embedder, allowed);

if (allowed) {