chrome/browser/browsing_data/browsing_data_remover.cc - Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 2184823007: Add a feature which, when enabled, blocks permissions after X prompt dismissals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unify implementation in permission_context_base, make log static Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browsing_data/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc

index d92f382b086a60a8fd8146b59027aea39bef7c05..8b9774ac4737bb0335bb95e1097e761aebc2ba37 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover.cc

@@ -32,6 +32,7 @@

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"

#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"

#include "chrome/browser/password_manager/password_store_factory.h"

+#include "chrome/browser/permissions/permission_prompt_decision_log.h"

#include "chrome/browser/prerender/prerender_manager.h"

#include "chrome/browser/prerender/prerender_manager_factory.h"

#include "chrome/browser/profiles/profile.h"

@@ -457,6 +458,9 @@ void BrowsingDataRemover::RemoveImpl(

extension_prefs->ClearLastLaunchTimes();

#endif

+ // Clear permission dismissal counts as they are origin-keyed.

+ PermissionPromptDecisionLog::RemoveCountsByUrl(profile_, filter);

// The power consumption history by origin contains details of websites

// that were visited.

// TODO(dmurph): Support all backends with filter (crbug.com/113621).

« no previous file with comments | « no previous file | chrome/browser/permissions/permission_context_base.h » ('j') | chrome/browser/permissions/permission_context_base.h » ('J')