Add a feature which, when enabled, blocks permissions after X prompt dismissals.

chrome/browser/browsing_data/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 #include <string>
 
@@ skipping 14 matching lines @@
 #include "chrome/browser/domain_reliability/service_factory.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/history/web_history_service_factory.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/media/media_device_id_salt.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
+#include "chrome/browser/permissions/permission_decision_auto_blocker.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/sessions/tab_restore_service_factory.h"
 #include "chrome/browser/web_data_service_factory.h"
 #include "chrome/common/features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
@@ skipping 739 matching lines @@
                    weak_ptr_factory_.GetWeakPtr());
     watcher_.StartWatching(event, watcher_callback);
   }
 #endif
 
   if (remove_mask & REMOVE_SITE_USAGE_DATA) {
     ClearSettingsForOneTypeWithPredicate(
         HostContentSettingsMapFactory::GetForProfile(profile_),
         CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT,
         base::Bind(&ForwardPrimaryPatternCallback, same_pattern_filter));
+

[msramek, 2016/08/08 17:09:53]

Please add a test to BrowsingDataRemoverTest.

[dominickn, 2016/08/09 08:31:24]

Done.

+    PermissionDecisionAutoBlocker::RemoveCountsByUrl(profile_, filter);

[msramek, 2016/08/08 17:09:53]

The guarantee that we want to give when the user deletes history is that no URLs
remain stored anywhere (except search engines and content settings which have
their own UI, so they're auditable separately).

So please add a REMOVE_HISTORY condition as well - for example by moving this
three lines below.

Unless this listens to local history item deletions, as SITE_ENGAGEMENT does
(IIRC). In that case it's OK not to specify REMOVE_HISTORY explicitly, but add a
comment instead.

[dominickn, 2016/08/09 08:31:24]

Done.

   }
 
   if (remove_mask & REMOVE_SITE_USAGE_DATA || remove_mask & REMOVE_HISTORY) {
     ClearSettingsForOneTypeWithPredicate(
         HostContentSettingsMapFactory::GetForProfile(profile_),
         CONTENT_SETTINGS_TYPE_APP_BANNER,
         base::Bind(&ForwardPrimaryPatternCallback, same_pattern_filter));
   }
 
   if (remove_mask & REMOVE_PASSWORDS) {
@@ skipping 604 matching lines @@
   waiting_for_clear_offline_page_data_ = false;
   NotifyIfDone();
 }
 #endif
 
 void BrowsingDataRemover::OnClearedDomainReliabilityMonitor() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   waiting_for_clear_domain_reliability_monitor_ = false;
   NotifyIfDone();
 }