Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2184823005: Add flag for the counters and time selection UI in CBD (Closed)

Created:
4 years, 4 months ago by ioanap
Modified:
4 years, 4 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org, msramek, melandory
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag for the counters and time selection UI in Clear Browsing Data. BUG=620318 Committed: https://crrev.com/d798d0b20e003f4f210911ef2ce1fb096221f2c1 Cr-Commit-Position: refs/heads/master@{#408150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/chrome/browser/experimental_flags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
ioanap
Please take a look! Thank you, Ioana
4 years, 4 months ago (2016-07-27 16:23:43 UTC) #7
sdefresne
lgtm
4 years, 4 months ago (2016-07-27 16:26:52 UTC) #8
sdefresne
nit: can you expand CBD in description?
4 years, 4 months ago (2016-07-27 16:27:11 UTC) #9
ioanap
On 2016/07/27 16:27:11, sdefresne wrote: > nit: can you expand CBD in description? Done, landing ...
4 years, 4 months ago (2016-07-27 16:29:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823005/1
4 years, 4 months ago (2016-07-27 16:29:50 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 16:34:10 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:35:21 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d798d0b20e003f4f210911ef2ce1fb096221f2c1
Cr-Commit-Position: refs/heads/master@{#408150}

Powered by Google App Engine
This is Rietveld 408576698