Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 2184823004: [Editing][CodeHealth] Remove redundant Editabletype arguments in layoutObjectIsRichlyEditable (Closed)

Created:
4 years, 4 months ago by yoichio
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Editing][CodeHealth] Remove redundant Editabletype arguments in layoutObjectIsRichlyEditable That's because it is always ContentIsEditable. This CL also rename layoutObjectIsRichlyEditable to hasRichlyEditableStyle aligning with hasEditableStyle. Also rename static functions: hasEditableStyle- > hasEditableLevel isEditableToAccessibility -> hasAXEditableLevel TEST=No change in behavior Committed: https://crrev.com/ea062aa9a0f814b1ba88bbe3151e057e5aba60e8 Cr-Commit-Position: refs/heads/master@{#408052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 4 chunks +10 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yoichio
4 years, 4 months ago (2016-07-27 05:24:19 UTC) #6
yosin_UTC9
lgtm
4 years, 4 months ago (2016-07-27 05:41:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823004/1
4 years, 4 months ago (2016-07-27 05:55:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 05:59:21 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 06:01:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea062aa9a0f814b1ba88bbe3151e057e5aba60e8
Cr-Commit-Position: refs/heads/master@{#408052}

Powered by Google App Engine
This is Rietveld 408576698