Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2184803002: Reland of [Android] Reland Galaxy s5 perf bots to run using platform mode. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2187483002/ ) Reason for revert: Fixed with https://codereview.chromium.org/2187513002/ Original issue's description: > Revert of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2177863004/ ) > > Reason for revert: > the sharded perf tests step fails when one or more devices are blacklisted. > > Original issue's description: > > [Android] Reland Galaxy s5 perf bots to run using platform mode. > > > > BUG=615157, 630627, 630640 > > > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/772e098a3f629dfeadab58212623a07e54ee902a > > TBR=stip@chromium.org,rnephew@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=615157, 630627, 630640 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/93b972af676e8098ebc020db5600b1197a761982 TBR=stip@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615157, 630627, 630640 Committed: https://chromium.googlesource.com/chromium/tools/build/+/525217b0d1284f1b2a9ddd691b099f9a4f894349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rnephew (Reviews Here)
Created Reland of [Android] Reland Galaxy s5 perf bots to run using platform mode.
4 years, 4 months ago (2016-07-26 16:40:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184803002/1
4 years, 4 months ago (2016-07-26 16:40:41 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-07-26 16:40:43 UTC) #5
jbudorick
lgtm
4 years, 4 months ago (2016-07-26 16:44:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184803002/1
4 years, 4 months ago (2016-07-26 16:44:41 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 16:44:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/525217b0d1284f1b2a9d...

Powered by Google App Engine
This is Rietveld 408576698