headless: Enable GL support by default

headless: Enable GL support by default

Enable GL support by default so that WebGL and GL-based canvas rendering
can be used. GL support can still be disabled to save resources if
necessary.

BUG=617551
Committed: https://crrev.com/ff3c237e3b02f91c9d8c03006c5fc205bd4e05f7
Cr-Commit-Position: refs/heads/master@{#408121}

[Sami, 2016-07-26 14:28:34]

Description was changed from

==========
headless: Enable GL support by default

Enable GL support by default so that WebGL and GL-based canvas rendering
can be used. GL support can still be disabled to save resources if
necessary.

BUG=617551
==========

to

==========
headless: Enable GL support by default

Enable GL support by default so that WebGL and GL-based canvas rendering
can be used. GL support can still be disabled to save resources if
necessary.

BUG=617551
==========

[Sami, 2016-07-26 14:28:34]

skyostil@chromium.org changed reviewers:
+ altimin@chromium.org, sievers@chromium.org

[Sami, 2016-07-26 14:29:06]

+altimin@ for headless and +sievers@ for new ui/gl dependency. PTAL.

[altimin, 2016-07-26 14:47:06]

LGTM with one nit.

https://codereview.chromium.org/2184763002/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2184763002/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:168:
"document.createElement('canvas').getContext('"
nit: Can we try to format this code more nicely?

[no sievers, 2016-07-26 17:52:19]

On 2016/07/26 14:29:06, Sami wrote:
> +altimin@ for headless and +sievers@ for new ui/gl dependency. PTAL.

lgtm

[Sami, 2016-07-27 13:47:06]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-07-27 13:47:19]

The CQ bit was unchecked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-07-27 13:47:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-07-27 13:58:50]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-07-27 13:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, altimin@chromium.org
Link to the patchset: https://codereview.chromium.org/2184763002/#ps20001
(title: "Rebased and reformatted")

[commit-bot: I haz the power, 2016-07-27 13:59:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-07-27 14:26:05]

https://codereview.chromium.org/2184763002/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/2184763002/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:168:
"document.createElement('canvas').getContext('"
On 2016/07/26 14:47:05, altimin wrote:
> nit: Can we try to format this code more nicely?

Definitely, done.

[commit-bot: I haz the power, 2016-07-27 14:42:14]

Description was changed from

==========
headless: Enable GL support by default

Enable GL support by default so that WebGL and GL-based canvas rendering
can be used. GL support can still be disabled to save resources if
necessary.

BUG=617551
==========

to

==========
headless: Enable GL support by default

Enable GL support by default so that WebGL and GL-based canvas rendering
can be used. GL support can still be disabled to save resources if
necessary.

BUG=617551
==========

[commit-bot: I haz the power, 2016-07-27 14:42:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 14:43:33]

Description was changed from

==========
headless: Enable GL support by default

Enable GL support by default so that WebGL and GL-based canvas rendering
can be used. GL support can still be disabled to save resources if
necessary.

BUG=617551
==========

to

==========
headless: Enable GL support by default

Enable GL support by default so that WebGL and GL-based canvas rendering
can be used. GL support can still be disabled to save resources if
necessary.

BUG=617551

Committed: https://crrev.com/ff3c237e3b02f91c9d8c03006c5fc205bd4e05f7
Cr-Commit-Position: refs/heads/master@{#408121}
==========

[commit-bot: I haz the power, 2016-07-27 14:43:34]

Patchset 2 (id:??) landed as
https://crrev.com/ff3c237e3b02f91c9d8c03006c5fc205bd4e05f7
Cr-Commit-Position: refs/heads/master@{#408121}