Remove .isolated file rewriting.

Remove .isolated file rewriting.

It is not necessary anymore as all windows builders have been converted to
ninja.

R=thakis@chromium.org
BUG=311622
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260707

[M-A Ruel, 2014-03-30 01:40:33]

I did a quick look but I'm not 100% sure, can you confirm first?

[Nico, 2014-03-30 06:06:56]

Do any stable branch builders use isolated files for anything? The ninja default
switch on windows was at r243782, stable is at m33 which branched at r241107.

[Nico, 2014-03-30 06:09:40]

(I suppose build_directory.py and compile.py can be simplified too once m34 goes
stable)

https://codereview.chromium.org/218473003/diff/1/scripts/slave/unittests/runi...
File scripts/slave/unittests/runisolatedtest_test.py (right):

https://codereview.chromium.org/218473003/diff/1/scripts/slave/unittests/runi...
scripts/slave/unittests/runisolatedtest_test.py:41:
r'..\build\Release/browser_test.exe'],
..\out\Release/...

https://codereview.chromium.org/218473003/diff/1/scripts/slave/unittests/runi...
scripts/slave/unittests/runisolatedtest_test.py:42: 'files': {
r'build\Release\testdata': {} },
out\Release\testdata

https://codereview.chromium.org/218473003/diff/1/scripts/slave/unittests/runi...
scripts/slave/unittests/runisolatedtest_test.py:47: 'PRODUCT_DIR' :
'../build/Release'
Change this to ../out/Release

[M-A Ruel, 2014-03-30 14:00:38]

On 2014/03/30 06:06:56, Nico wrote:
> Do any stable branch builders use isolated files for anything? The ninja
default
> switch on windows was at r243782, stable is at m33 which branched at r241107.

Officials are not using it.

On 2014/03/30 06:09:40, Nico wrote:
> (I suppose build_directory.py and compile.py can be simplified too once m34
goes
> stable)

Yep.

About the unit test, what about just deleting it? It's not testing anything
relevant anymore.

[Nico, 2014-03-30 18:24:45]

On 2014/03/30 14:00:38, M-A Ruel wrote:
> On 2014/03/30 06:06:56, Nico wrote:
> > Do any stable branch builders use isolated files for anything? The ninja
> default
> > switch on windows was at r243782, stable is at m33 which branched at
r241107.
> 
> Officials are not using it.
> 
> On 2014/03/30 06:09:40, Nico wrote:
> > (I suppose build_directory.py and compile.py can be simplified too once m34
> goes
> > stable)
> 
> Yep.
> 
> About the unit test, what about just deleting it? It's not testing anything
> relevant anymore.

Dunno, it was there before I changed the isolated rewriting – so someone (you, I
guess? :-) ) thought it does test something useful?

[M-A Ruel, 2014-03-31 12:33:06]

Replaced 'build' with 'out'

[Nico, 2014-03-31 15:22:34]

lgtm with unrelated changes reverted

https://codereview.chromium.org/218473003/diff/20001/scripts/slave/unittests/...
File scripts/slave/unittests/runisolatedtest_test.py (right):

https://codereview.chromium.org/218473003/diff/20001/scripts/slave/unittests/...
scripts/slave/unittests/runisolatedtest_test.py:100: u'version': u'1.0',
(not sure about the reordering and adding u prefixes everywhere; expected_data
now looks pretty different from data a few lines above for no good reason, and
this looks like an unrelated change. I'd undo the reordering and remove the u
prefixes, and keep the r above)

https://codereview.chromium.org/218473003/diff/20001/scripts/slave/unittests/...
scripts/slave/unittests/runisolatedtest_test.py:113: unittest.TestCase.maxDiff =
None
This looks unrelated too

[M-A Ruel, 2014-03-31 20:35:11]

https://codereview.chromium.org/218473003/diff/20001/scripts/slave/unittests/...
File scripts/slave/unittests/runisolatedtest_test.py (right):

https://codereview.chromium.org/218473003/diff/20001/scripts/slave/unittests/...
scripts/slave/unittests/runisolatedtest_test.py:100: u'version': u'1.0',
On 2014/03/31 15:22:34, Nico wrote:
> (not sure about the reordering and adding u prefixes everywhere; expected_data
> now looks pretty different from data a few lines above for no good reason, and
> this looks like an unrelated change. I'd undo the reordering and remove the u
> prefixes, and keep the r above)

Done.

https://codereview.chromium.org/218473003/diff/20001/scripts/slave/unittests/...
scripts/slave/unittests/runisolatedtest_test.py:113: unittest.TestCase.maxDiff =
None
On 2014/03/31 15:22:34, Nico wrote:
> This looks unrelated too

Done.

[M-A Ruel, 2014-03-31 23:55:03]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2014-03-31 23:55:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/218473003/40001

[commit-bot: I haz the power, 2014-03-31 23:56:02]

Change committed as 260707