Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2184723002: Add special Windows instructions for getting SKPs (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add special Windows instructions for getting SKPs BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184723002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2184723002 Committed: https://skia.googlesource.com/skia/+/fe8d2cf520b78faec09ecb95ebaf3dfadc1658fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M site/dev/testing/skps.md View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Brian Osman
4 years, 4 months ago (2016-07-26 13:23:48 UTC) #3
jcgregorio
lgtm
4 years, 4 months ago (2016-07-26 13:31:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184723002/1
4 years, 4 months ago (2016-07-26 13:34:46 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 13:43:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fe8d2cf520b78faec09ecb95ebaf3dfadc1658fc

Powered by Google App Engine
This is Rietveld 408576698