Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2184683004: [gn] Fix sanitizer configs (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix sanitizer configs This prepares for https://codereview.chromium.org/2188693002/ With the current configuration, sanitizers wouldn't be used at all. The clang configuration is automatically derived in GN. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/3dedc3e5cec1f1198cff740ccfc55aed8b6447aa Cr-Commit-Position: refs/heads/master@{#38089}

Patch Set 1 #

Patch Set 2 : Add blacklist files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M infra/mb/mb_config.pyl View 4 chunks +4 lines, -4 lines 0 comments Download
A tools/memory/asan/blacklist.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A tools/memory/tsan_v2/ignores.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL
4 years, 4 months ago (2016-07-27 09:39:11 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-27 09:42:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184683004/1
4 years, 4 months ago (2016-07-27 09:57:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 09:59:08 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 09:59:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dedc3e5cec1f1198cff740ccfc55aed8b6447aa
Cr-Commit-Position: refs/heads/master@{#38089}

Powered by Google App Engine
This is Rietveld 408576698