Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

Issue 2184683002: Show content suggestions from all categories on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge the two loops into one Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
index ed0dd39dc0c27838594b900d15788f72d3522f5d..9f3ab3e37db64a5c0d69d012112b549a314638e3 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
@@ -13,6 +13,12 @@ using offline_pages::OfflinePageItem;
namespace ntp_snippets {
+namespace {
+
+const int kMaxSuggestionsCount = 5;
+
+} // namespace
+
OfflinePageSuggestionsProvider::OfflinePageSuggestionsProvider(
OfflinePageModel* offline_page_model)
: ContentSuggestionsProvider({ContentSuggestionsCategory::OFFLINE_PAGES}),
@@ -97,6 +103,9 @@ void OfflinePageSuggestionsProvider::OnOfflinePagesLoaded(
std::vector<ContentSuggestion> suggestions;
for (const OfflinePageItem& item : result) {
+ // TODO(pke): Make sure the URL is actually opened as an offline URL.
+ // Currently, the browser opens the offline URL and then immediately
+ // redirects to the online URL if the device is online.
ContentSuggestion suggestion(
MakeUniqueID(ContentSuggestionsCategory::OFFLINE_PAGES,
base::IntToString(item.offline_id)),
@@ -110,6 +119,8 @@ void OfflinePageSuggestionsProvider::OnOfflinePagesLoaded(
suggestion.set_publish_date(item.creation_time);
suggestion.set_publisher_name(item.url.host());
suggestions.emplace_back(std::move(suggestion));
+ if (suggestions.size() == kMaxSuggestionsCount)
+ break;
}
observer_->OnNewSuggestions(ContentSuggestionsCategory::OFFLINE_PAGES,
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698