Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

Issue 2184683002: Show content suggestions from all categories on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
index ed0dd39dc0c27838594b900d15788f72d3522f5d..25e9b4ebf0b998f7066ed0dfae422d20d253b35c 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
@@ -97,6 +97,9 @@ void OfflinePageSuggestionsProvider::OnOfflinePagesLoaded(
std::vector<ContentSuggestion> suggestions;
for (const OfflinePageItem& item : result) {
+ // TODO(pke): Make sure the URL is actually opened as an offline URL.
+ // Currently, the browser opens the offline URL and then immediately
+ // redirects to the online URL if the device is online.
ContentSuggestion suggestion(
MakeUniqueID(ContentSuggestionsCategory::OFFLINE_PAGES,
base::IntToString(item.offline_id)),

Powered by Google App Engine
This is Rietveld 408576698