Show content suggestions from all categories on the NTP

components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h"
 
 #include "base/bind.h"
 #include "base/strings/string_number_conversions.h"
 
 using offline_pages::MultipleOfflinePageItemResult;
@@ skipping 77 matching lines @@
       base::Bind(&OfflinePageSuggestionsProvider::OnOfflinePagesLoaded,
                  base::Unretained(this)));
 }
 
 void OfflinePageSuggestionsProvider::OnOfflinePagesLoaded(
     const MultipleOfflinePageItemResult& result) {
   NotifyStatusChanged(ContentSuggestionsCategoryStatus::AVAILABLE);
   if (!observer_)
     return;
 
+  int counter = 0;
   std::vector<ContentSuggestion> suggestions;
   for (const OfflinePageItem& item : result) {
+    // TODO(pke): Make sure the URL is actually opened as an offline URL.
+    // Currently, the browser opens the offline URL and then immediately
+    // redirects to the online URL if the device is online.
     ContentSuggestion suggestion(
         MakeUniqueID(ContentSuggestionsCategory::OFFLINE_PAGES,
                      base::IntToString(item.offline_id)),
         item.GetOfflineURL());
 
     // TODO(pke): Sort my most recently visited and only keep the top one of
     // multiple entries for the same URL.
     // TODO(pke): Get more reasonable data from the OfflinePageModel here.
     suggestion.set_title(item.url.spec());
     suggestion.set_snippet_text(std::string());
     suggestion.set_publish_date(item.creation_time);
     suggestion.set_publisher_name(item.url.host());
     suggestions.emplace_back(std::move(suggestion));
+    // TODO(pke): Refine the number of offline pages to be returned, introduce
+    // a constant?

[Marc Treib, 2016/07/26 14:00:00]

Yup, you should probably introduce a constant :)
Also, you don't need a counter here, you can just check suggestions.size()

[Philipp Keck, 2016/07/26 15:47:20]

Good idea. Constant is there, I put a question about the desired value in the
PRD.

+    if (5 == ++counter)
+      break;
   }
 
   observer_->OnNewSuggestions(ContentSuggestionsCategory::OFFLINE_PAGES,
                               std::move(suggestions));
 }
 
 void OfflinePageSuggestionsProvider::NotifyStatusChanged(
     ContentSuggestionsCategoryStatus new_status) {
   if (category_status_ == new_status)
     return;
   category_status_ = new_status;
 
   if (!observer_)
     return;
   observer_->OnCategoryStatusChanged(ContentSuggestionsCategory::OFFLINE_PAGES,
                                      new_status);
 }
 
 }  // namespace ntp_snippets