Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2184673002: [base] Use thread safe localtime_r() instead of localtime(). (Closed)

Created:
4 years, 4 months ago by Igor Sheludko
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[base] Use thread safe localtime_r() instead of localtime(). BUG=chromium:631269 Committed: https://crrev.com/3c7bff3698723687ec28fe4ab0aaa0c04a3cfd0a Cr-Commit-Position: refs/heads/master@{#38168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M src/base/platform/platform-aix.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/base/platform/platform-cygwin.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/base/platform/platform-freebsd.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/base/platform/platform-linux.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/base/platform/platform-macos.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/base/platform/platform-openbsd.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/base/platform/platform-posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-qnx.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/base/platform/platform-solaris.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 4 months ago (2016-07-29 09:12:56 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-29 09:16:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184673002/1
4 years, 4 months ago (2016-07-29 09:24:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 09:48:30 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 09:51:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c7bff3698723687ec28fe4ab0aaa0c04a3cfd0a
Cr-Commit-Position: refs/heads/master@{#38168}

Powered by Google App Engine
This is Rietveld 408576698