Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tests/git_cl_test.py

Issue 2184643004: git cl set-commit: fix for Rietveld if cq dry run is active. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index a4a7a5806c88357ef4ef0c2d9e47fb75e3ac3228..286290fa60630ba943af59c4521a8834e455938c 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -1466,8 +1466,8 @@ class TestGitCl(TestCase):
self.assertIsNone(cl.EnsureAuthenticated(force=False))
def test_cmd_set_commit_rietveld(self):
- self.mock(git_cl._RietveldChangelistImpl, 'SetFlag',
- lambda _, f, v: self._mocked_call(['SetFlag', f, v]))
+ self.mock(git_cl._RietveldChangelistImpl, 'SetFlags',
+ lambda _, v: self._mocked_call(['SetFlags', v]))
self.calls = [
((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
@@ -1476,7 +1476,7 @@ class TestGitCl(TestCase):
((['git', 'config', 'rietveld.server'],), ''),
((['git', 'config', 'branch.feature.rietveldserver'],),
'https://codereview.chromium.org'),
- ((['SetFlag', 'commit', '1'], ), ''),
+ ((['SetFlags', {'commit': '1', 'cq_dry_run': '0'}], ), ''),
]
self.assertEqual(0, git_cl.main(['set-commit']))
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698